Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTE-877] deprecate OI indexer update event (backport #2499) #2507

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[OTE-877] deprecate OI indexer update event (backport #2499) #2507

merged 2 commits into from
Oct 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2024

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features
    • Introduced LiquidityTierUpsertEventV2 for enhanced liquidity tier management.
  • Deprecations
    • Marked several event interfaces as deprecated, including OpenInterestUpdateEventV1 and OpenInterestUpdate.
  • Bug Fixes
    • Improved testing framework for long-term and short-term order functionalities, enhancing coverage and robustness.
  • Tests
    • Added new test cases for order placement, cancellation, and execution scenarios in both long-term and short-term orders.
    • Updated tests in the perpetuals module for better error handling and functionality validation.
This is an automatic backport of pull request #2499 done by [Mergify](https://mergify.com).

@affanv14 @mergify
[OTE-877] deprecate OI indexer update event (#2499)
55eb238 
(cherry picked from commit 4208b7b)

# Conflicts:
#	protocol/indexer/events/events.pb.go
@mergify mergify bot added the conflicts label Oct 16, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Oct 16, 2024

Cherry-pick of 4208b7b has failed:

On branch mergify/bp/release/protocol/v6.x/pr-2499
Your branch is up to date with 'origin/release/protocol/v6.x'.

You are currently cherry-picking commit 4208b7be.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   indexer/packages/v4-protos/src/codegen/dydxprotocol/indexer/events/events.ts
	modified:   proto/dydxprotocol/indexer/events/events.proto
	modified:   protocol/x/clob/e2e/long_term_orders_test.go
	modified:   protocol/x/clob/e2e/short_term_orders_test.go
	modified:   protocol/x/perpetuals/abci.go
	modified:   protocol/x/perpetuals/abci_test.go
	modified:   protocol/x/perpetuals/keeper/perpetual.go
	modified:   protocol/x/perpetuals/keeper/perpetual_test.go
	modified:   protocol/x/perpetuals/types/types.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   protocol/indexer/events/events.pb.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@linear Linear
Copy link

linear bot commented Oct 16, 2024

OTE-877 Deprecate protocol oi update event

@mergify mergify bot mentioned this pull request Oct 16, 2024
Merged
6 tasks
@affanv14 affanv14 merged commit 2a62823 into release/protocol/v6.x Oct 17, 2024
39 of 40 checks passed
@affanv14 affanv14 deleted the mergify/bp/release/protocol/v6.x/pr-2499 branch October 17, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dydxwill dydxwill dydxwill approved these changes

Assignees

@affanv14 affanv14

Labels
conflicts indexer proto protocol
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dydxwill @affanv14